Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: add amazon nova support (text) only #10021

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

EriksonBahr
Copy link

@EriksonBahr EriksonBahr commented Dec 19, 2024

Motivation and Context

Add support for amazon nova.

Description

This PR adds amazon nova support. Also re-structures existing Titan files.

Contribution Checklist

Sorry, something went wrong.

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Dec 19, 2024
@github-actions github-actions bot changed the title add amazon nova support (text) only .Net: add amazon nova support (text) only Dec 19, 2024
@EriksonBahr
Copy link
Author

@microsoft-github-policy-service agree

@EriksonBahr please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@RogerBarreto
Copy link
Member

@EriksonBahr Thanks for the amazing contribution, some extra conflicts needs to be addressed. Happy new year! 🎉

@RogerBarreto RogerBarreto added the PR: feedback to address Waiting for PR owner to address comments/questions label Jan 7, 2025
@RogerBarreto
Copy link
Member

@EriksonBahr, let me know if you plan on applying the suggestions above.

@EriksonBahr
Copy link
Author

@EriksonBahr, let me know if you plan on applying the suggestions above.

Should get this moving next week

@EriksonBahr EriksonBahr force-pushed the add-amazon-nova-support branch from 7a2e36d to 0d1bee7 Compare February 1, 2025 20:05
@EriksonBahr
Copy link
Author

I synced with main and re-done my commit following the updated interfaces. Also, updated the structure, indeed looks much better now.

@RogerBarreto RogerBarreto marked this pull request as ready for review February 6, 2025 14:37
@RogerBarreto RogerBarreto requested a review from a team as a code owner February 6, 2025 14:37
@RogerBarreto RogerBarreto removed the PR: feedback to address Waiting for PR owner to address comments/questions label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
Status: Community PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants